New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimPlugins.vim-go: set g:go_bin_path to work with pure nix-shell #86626
Conversation
- It requires gopls, but it's missing because it's no longer provided by gotools. - It was relying on PATH to find the Go compiler. I've made an update to the plugin so it relies on g:go_bin_path when calling system() or when starting a job. I've filed a pull request upstream to fix this: fatih/vim-go#2876
The pull request was not accepted upstream, but I still believe that this is the right thing to do as far as the plugin goes. @jonringer what do you think? |
I marked this as stale due to inactivity. → More info |
I am not sure this is the right approach and the patch probably breaks often. |
I'm concerned the same. I intend to go back upstream with a different less-intrusive patch to allow it to be pure. If it was not accepted and we care about its purity then I don't see another approach :| |
also might be possible to use |
I marked this as stale due to inactivity. → More info |
this is too big a deviation from upstream. If setting g:go_bin_path is enough, you could add it to this list I am building up #172538 |
can we close this ? |
Motivation for this change
Note My patch upstream works for Linux but will definitely break Windows support. I'm not sure we have any Windows use case for this.
Test NeoVim
Test Vim
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)