Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unar: 1.10.1 -> 1.10.7 #86628

Merged
merged 1 commit into from May 3, 2020
Merged

unar: 1.10.1 -> 1.10.7 #86628

merged 1 commit into from May 3, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Quite a lot of fixes upstream and build from the public repo as opposed
to a zip file that was out of date anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

I was using 7z as my general unpacker and obviously needed a substitute. Someone mentioned unar which was probably just as riddled with exploits waiting to be taken advantage of as it hadn't been updated in years either, so this changes it to a recent, supported version.

Further to #86417 and #85780.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/10

@ghost
Copy link

ghost commented May 3, 2020

I'm currently testing this PR (as a replacement for the old p7zip) and I couldn't manage to build it:

gcc: error: unar.m: Objective-C compiler not installed on this system
gcc: error: CommandLineCommon.m: Objective-C compiler not installed on this system

Any suggestions ?

@mweinelt
Copy link
Member

mweinelt commented May 3, 2020 

❯ nixpkgs-review pr 86628
[...]
2 packages built:
bookworm unar

The binaries are executable. LGTM.

@peterhoeg
Copy link
Member Author

and I couldn't manage to build it:

I'm not sure what problem you hit, but it builds and runs for both me and @mweinelt as well as @GrahamcOfBorg.

@peterhoeg peterhoeg merged commit 5fda26c into NixOS:master May 3, 2020
@peterhoeg
Copy link
Member Author

And thanks for verifying it all!

@peterhoeg peterhoeg deleted the f/unar branch May 3, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @nixos-discourse @mweinelt