Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wordfreq: 2.2.0 -> 2.3.2 #86664

Merged
merged 2 commits into from May 3, 2020
Merged

python3Packages.wordfreq: 2.2.0 -> 2.3.2 #86664

merged 2 commits into from May 3, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 3, 2020 •
edited

Motivation for this change

Noticed it was broken when reviewing another PR

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/86664
1 package failed to build:
python38Packages.wordfreq

3 package built:
python37Packages.langcodes python37Packages.wordfreq python38Packages.langcodes

@jonringer jonringer requested a review from FRidh as a code owner May 3, 2020 18:15
@jonringer
Copy link
Contributor Author

python38 still fails due to mecab-python3

builder for '/nix/store/w7kkhar1vjl8a8hnssdgxkxdc3av107n-python3.8-mecab-python3-0.996.3.drv' failed with exit code 1; last 10 log lines:
  creating build/temp.linux-x86_64-3.8/src
  creating build/temp.linux-x86_64-3.8/src/MeCab
  gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/nix/store/dsv05prb956b1a8z132504wr3ar443r7-mecab-0.996/include -I/nix/store/dplyazkw1b1qs6azc9xxrvz3ib26j9ds-python3-3.8.2/include/python3.8 -c src/MeCab/MeCab_wrap.cpp -o build/temp.linux-x86_64-3.8/src/MeCab/MeCab_wrap.o -Wno-unused-variable
  src/MeCab/MeCab_wrap.cpp: In function ‘void SwigPyStaticVar_dealloc(PyDescrObject*)’:
  src/MeCab/MeCab_wrap.cpp:3120:3: error: ‘_PyObject_GC_UNTRACK’ was not declared in this scope; did you mean ‘PyObject_GC_UnTrack’?
   3120 |   _PyObject_GC_UNTRACK(descr);
        |   ^~~~~~~~~~~~~~~~~~~~
        |   PyObject_GC_UnTrack
  error: command 'gcc' failed with exit status 1
  builder for '/nix/store/w7kkhar1vjl8a8hnssdgxkxdc3av107n-python3.8-mecab-python3-0.996.3.drv' failed with exit code 1
cannot build derivation '/nix/store/lqgkbk1lykppz8wl6h9wdvvm14g4h979-python3.8-wordfreq-2.3.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y8q5yk9mjjbymkbx0amrf116pwfid3vr-env.drv': 1 dependencies couldn't be built

@ofborg ofborg bot requested a review from ixxie May 3, 2020 18:25
@jonringer jonringer merged commit 132664e into NixOS:master May 3, 2020
@jonringer jonringer deleted the bump-word-freq branch August 15, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@ixxie ixxie Awaiting requested review from ixxie

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer