squeak: 4.10.2.2614 -> 202003021730 #86741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
requested changes
Dec 8, 2020
| @@ -1,33 +1,55 @@ | |||
| { stdenv, fetchurl, cmake, coreutils, dbus, freetype, glib, gnused | |||
| , libpthreadstubs, pango, pkgconfig, libpulseaudio, which }: | |||
| { stdenv, fetchFromGitHub, lib, alsaLib, autoconf, automake, bash, clang, coreutils | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchFromGitHub, lib, alsaLib, autoconf, automake, bash, clang, coreutils | |
| { stdenv, fetchFromGitHub, alsaLib, autoconf, automake, bash, clang, coreutils |
Comment on lines
+10
to
+12
| owner="OpenSmalltalk"; | ||
| repo="opensmalltalk-vm"; | ||
| rev="${version}"; |
There was a problem hiding this comment.
Suggested change
| owner="OpenSmalltalk"; | |
| repo="opensmalltalk-vm"; | |
| rev="${version}"; | |
| owner = "OpenSmalltalk"; | |
| repo = "opensmalltalk-vm"; | |
| rev = version; |
| configurePhase = '' | ||
| unix/cmake/configure --prefix=$out --enable-mpg-{mmx,pthreads} | ||
| buildPhase = '' | ||
| find . -type f -exec sed -i -e 's/\/usr\/bin\/env/${lib.escape ["/"] coreutils.outPath}\/bin\/env/g' {} \; |
There was a problem hiding this comment.
Suggested change
| find . -type f -exec sed -i -e 's/\/usr\/bin\/env/${lib.escape ["/"] coreutils.outPath}\/bin\/env/g' {} \; | |
| find . -type f -exec sed -i -e 's/\/usr\/bin\/env/${stdenv.lib.escape ["/"] coreutils.outPath}\/bin\/env/g' {} \; |
|
Please squash the commits together. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
11 tasks
bb010g
added a commit
to bb010g/nixpkgs
that referenced
this pull request
Aug 12, 2021
Credit to @BenBals for starting work on this patch in <NixOS#86741>.
|
Closed because this is continued in #133310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Squeak package has not been updated for quite some time. I have updated it to use the opensmalltalk repo where the current Squeak development happens.
This is my first substantial contribution. I am happy to receive feedback and improve it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)