Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hostapd: country selection, CRDA, logging #86712

Merged
merged 4 commits into from May 5, 2020
Merged

nixos/hostapd: country selection, CRDA, logging #86712

merged 4 commits into from May 5, 2020

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented May 4, 2020

Motivation for this change

Add to the hostapd module:

  • add a country code option to unlock channels not allowed by default

  • enable CRDA (needed for the country code to work)

  • configurable log level

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Am I supposed to cc the pkg maintainers? @Phreedom @NinjaTrappeur

@rardiol
nixos/hostapd: use CRDA
151d32d 
Needed for regulatory compliance and unlocking some channels.
mweinelt
mweinelt approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Had one idea about enabling 802.11d when a country was set, what do you think?

nixos/modules/services/networking/hostapd.nix Show resolved Hide resolved
@Lassulus Lassulus merged commit ef0f57f into NixOS:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rardiol @mweinelt @Lassulus