osmium-tool: 1.11.1 -> 1.12.0 #86714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-g
approved these changes
May 4, 2020
There was a problem hiding this comment.
Diff LGTM.
Tests done:
- download from Cachix:
nix-store -r /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0 \ --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \ --option trusted-public-keys ' r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= '
- checked that the
osmiumbinary is still the only file installed by the packagenix run nixpkgs.tree -c tree /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0
/nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0 └── bin └── osmium 1 directory, 1 file - smoke-tested the included binary:
-
/nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0/bin/osmium --version
osmium version 1.12.0 libosmium version 2.15.4 Copyright (C) 2013-2020 Jochen Topf <jochen@topf.org> License: GNU GENERAL PUBLIC LICENSE Version 3 <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. -
(output looked sensible and identical to that produced with
/nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0/bin/osmium fileinfo $SOME_PBF_FILEn45lsdazsnd9642f2mxrxwvc9a173pc8-osmium-tool-1.11.1currently included in NixOS 20.03)
-
Ship it! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/osmcode/osmium-tool/releases.
meta.description for osmium-tool is: "Multipurpose command line tool for working with OpenStreetMap data based on the Osmium library"
meta.homepage for osmium-tool is: "https://osmcode.org/osmium-tool/"
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.12.0 with grep in /nix/store/mfmnmsfs06crlg6wk2a1vwjp6dmjyd6d-osmium-tool-1.12.0
directory tree listing: https://gist.github.com/c4592eaa4cc7ca4e22c7a29bc7469dd6
du listing: https://gist.github.com/65211b0642160271e6555afd223ed844
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of
nixpkgs-review11 package built:
- osmium-tool
Maintainer pings
cc @das-g for testing.