gitqlient: init at 1.1.0 #86706
gitqlient: init at 1.1.0 #86706
Conversation
| , qtbase, qmake | ||
| }: | ||
|
|
||
| with stdenv.lib; |
| mv $out/homeless-shelter/GitQlient/bin $out/bin | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
| meta = { | |
| meta = with lib; { |
| @@ -3693,6 +3693,8 @@ in | |||
|
|
|||
| gitaly = callPackage ../applications/version-management/gitlab/gitaly { }; | |||
|
|
|||
| gitqlient = qt5.callPackage ../applications/version-management/gitqlient { }; | |||
There was a problem hiding this comment.
It seems it is much more common to use
| gitqlient = qt5.callPackage ../applications/version-management/gitqlient { }; | |
| gitqlient = libsForQt5.callPackage ../applications/version-management/gitqlient { }; |
| buildInputs = [ qtbase ]; | ||
| nativeBuildInputs = [ qmake ]; |
There was a problem hiding this comment.
Not sure if these 2 lines are required when you use libsForQt5 in all-packages.nix.
There was a problem hiding this comment.
The first one is not needed, but the second one is required.
There was a problem hiding this comment.
As of 1.3.0, qtwebengine is required.
|
|
||
| meta = { | ||
| homepage = "https://github.com/francescmm/GitQlient"; | ||
| description = "GitQlient: Multi-platform Git client written with Qt"; |
There was a problem hiding this comment.
| description = "GitQlient: Multi-platform Git client written with Qt"; | |
| description = "Multi-platform Git client written with Qt"; |
colemickens
force-pushed
the
gitqlient
branch
4 times, most recently
from
1eb4758
to
f2ea8cc
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
| @@ -0,0 +1,34 @@ | |||
| { stdenv, mkDerivation, fetchFromGitHub | |||
There was a problem hiding this comment.
| { stdenv, mkDerivation, fetchFromGitHub | |
| { lib, mkDerivation, fetchFromGitHub |
|
1.3.0 is out. |
| meta = { | ||
| homepage = "https://github.com/francescmm/GitQlient"; | ||
| description = "GitQlient: Multi-platform Git client written with Qt"; | ||
| license = licenses.lgpl2; |
There was a problem hiding this comment.
| license = licenses.lgpl2; | |
| license = licenses.lgpl2Plus; |
| repo = "GitQlient"; | ||
| rev = "v${version}"; | ||
| sha256 = "048mmwx0nv7sb2cpwl1h8wqb4q7dcnkrrmhvq08yznylgdcgkgs1"; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
There is not submodules, at least now.
| @@ -0,0 +1,34 @@ | |||
| { stdenv, mkDerivation, fetchFromGitHub | |||
| , qtbase, qmake | |||
There was a problem hiding this comment.
| , qtbase, qmake | |
| , qtwebengine, qmake |
|
|
||
| mkDerivation rec { | ||
| pname = "GitQlient"; | ||
| version = "1.1.0"; |
There was a problem hiding this comment.
| version = "1.1.0"; | |
| version = "1.3.0"; |
| sha256 = "048mmwx0nv7sb2cpwl1h8wqb4q7dcnkrrmhvq08yznylgdcgkgs1"; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
| sha256 = "048mmwx0nv7sb2cpwl1h8wqb4q7dcnkrrmhvq08yznylgdcgkgs1"; | |
| fetchSubmodules = true; | |
| sha256 = "1j3mlf1yqfnm509pjvhfba754algrj94m15fxx61xkqdwkp611wz"; |
| fetchSubmodules = true; | ||
| }; | ||
|
|
||
| buildInputs = [ qtbase ]; |
There was a problem hiding this comment.
| buildInputs = [ qtbase ]; | |
| buildInputs = [ qtwebengine ]; |
| installFlags = [ "INSTALL_ROOT=$(out)" ]; | ||
|
|
||
| postInstall = '' | ||
| mv $out/homeless-shelter/GitQlient/bin $out/bin | ||
| ''; |
There was a problem hiding this comment.
| installFlags = [ "INSTALL_ROOT=$(out)" ]; | |
| postInstall = '' | |
| mv $out/homeless-shelter/GitQlient/bin $out/bin | |
| ''; | |
| qmakeFlags = [ "GitQlient.pro" ]; |
| homepage = "https://github.com/francescmm/GitQlient"; | ||
| description = "GitQlient: Multi-platform Git client written with Qt"; | ||
| license = licenses.lgpl2; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
| platforms = platforms.linux; | |
| platforms = platforms.unix; |
It works on darwin with the following change:
installPhase = lib.optionalString stdenv.isDarwin ''
mkdir -p $out/Applications
mv gitqlient.app $out/Applications
wrapQtApp $out/Applications/gitqlient.app/Contents/MacOS/gitqlient
'';
|
@colemickens Could you please update and undraft PR? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Abandoning this. There's lots of changes requested, I'm more likely to use |
stale
bot
removed
the
2.status: stale
Motivation for this change
Fixes: #86702.
Seems to build, launch, run okay. Going to test for a bit, maybe wait for the actual 1.1.0 release and then mark this as not-Draft.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)