onedrive: 2.3.13 -> 2.4.1 #86707
Closed
onedrive: 2.3.13 -> 2.4.1 #86707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmjones
reviewed
May 7, 2020
There was a problem hiding this comment.
@SRGOM I'm currently not running NixOS and therefore not using this onedrive package.
As I am unable to review this PR, feel free to handle this PR as you see fit.
Please remove me as a maintainer of the package in your next update too (assuming you're still maintaining it). 🙏
fadenb
approved these changes
May 25, 2020
There was a problem hiding this comment.
Just build the application with this patch on top and it seems to work fine (it is my first time using it so I may not know all the details to look out for yet).
The current 2.3.13 does no longer work with OneDrive (for Business).
We should think about backporting it to stable.
|
I will, I prefer my pr because it has doc changes which explain how to handle a breakage. I will bump up too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/abraunegg/onedrive/releases.
meta.description for onedrive is: "A complete tool to interact with OneDrive on Linux"
meta.homepage for onedrive is: "https://github.com/abraunegg/onedrive"
Updates performed
To inspect upstream changes
Release on GitHub
Compare changes on GitHub
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 2.4.1 with grep in /nix/store/48kf75ci42476k4nhi8gs7djx941b2yp-onedrive-2.4.1
directory tree listing: https://gist.github.com/d50c4b751315cf82eb0d54a1d0e8269e
du listing: https://gist.github.com/f4f1b4549f71d5b45c7abce02f936c9a
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of
nixpkgs-review11 package built:
- onedrive
Maintainer pings
cc @SRGOM @ianmjones for testing.