Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] kubeval: don't build against schema by default #86759

Merged
merged 2 commits into from May 4, 2020
Merged

[20.03] kubeval: don't build against schema by default #86759

merged 2 commits into from May 4, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented May 4, 2020

Motivation for this change

backport of #82816 to allow kubeval to be un-broken in 20.03.

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 and others added 2 commits May 4, 2020 13:06
@Mic92
kubeval: don't build against schema by default
879ce11 
kubeval-schema is a huge 7GB repository that we do not want
to build on hydra. Therefore make it optional.

(cherry picked from commit 9d144b8)
kubeval: remove broken state
8f84e12
@johanot
Copy link
Contributor Author

johanot commented May 4, 2020

Almost forgot: added an extra commit that removes the broken flag.

@ofborg ofborg bot requested a review from kalbasit May 4, 2020 11:20
@Mic92
Copy link
Member

Mic92 commented May 4, 2020

Result of nixpkgs-review pr 86759 1

1 package built:
- kubeval

@Mic92 Mic92 merged commit 6ea8340 into NixOS:release-20.03 May 4, 2020
@johanot johanot deleted the backport-kubeval-fix branch May 4, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @Mic92