Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] steam: fix more of generated runtime dependencies #86636

Merged
merged 5 commits into from May 4, 2020
Merged

[20.03] steam: fix more of generated runtime dependencies #86636

merged 5 commits into from May 4, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 3, 2020

Motivation for this change

PR #86619 did not contain all the necessary changes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak changed the title steam: fix more of generated runtime dependencies [20.03] steam: fix more of generated runtime dependencies May 3, 2020
@prusnak prusnak mentioned this pull request May 3, 2020
Merged
10 tasks
@prusnak prusnak added the 8.has: port to stable A PR already has a backport to the stable release. label May 3, 2020
@ofborg ofborg bot requested review from tadfisher and jagajaga May 3, 2020 13:10
@prusnak prusnak mentioned this pull request May 4, 2020
Closed
@prusnak
Copy link
Member Author

prusnak commented May 4, 2020

Fixes #86749

@flokli
Copy link
Contributor

flokli commented May 4, 2020

Was this something missing from the cherry-pick in #86619, or is this something that should target master first?

@prusnak
Copy link
Member Author

prusnak commented May 4, 2020 •
edited

@flokli I backported only a single-commit in the cherry-pick. Later I noticed more changes need to be backported than just a single-commit. This change is already in master. I just backported more stuff from master.

@flokli
Copy link
Contributor

flokli commented May 4, 2020

Okay, then please cherry-pick again with -x so people can find the corresponding commit in master. Also see https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches.

jonringer and others added 5 commits May 4, 2020 16:24
@jonringer @prusnak
steam-chrootenv: add lsof
666c378 
This adds support for "Launch Game" through the friends menu

(cherry picked from commit 4ca08a2)
@jonringer @prusnak
steamPackages.chrootenv: add file command
dd0d261 
Noticed that the setup.sh for steam was trying to call the file command.
I'm not sure what the ramifications are for these missing,
but some steam features are quietly disabled when they
don't follow happy paths.

(cherry picked from commit 9cd683c)
@jonringer @prusnak
steam.chrootenv: add udev
4142a18 
Needed by Shadow of the Tomb Raider

(cherry picked from commit 9d4aab7)
@nyanloutre @prusnak
steamrt: 1.20190624 -> 1.20200128
6986bc3 
(cherry picked from commit 8bd3cf2)
@nyanloutre @prusnak
steam.chrootenv: Add Prison Architect dependencies
281331a 
(cherry picked from commit 3a15a13)
@prusnak
Copy link
Member Author

prusnak commented May 4, 2020

@flokli I reworked the PR to include only cherry-picked commits from the master. Thanks!

@flokli flokli requested a review from mweinelt May 4, 2020 20:02
@mweinelt
Copy link
Member

mweinelt commented May 4, 2020

Result of nixpkgs-review pr 86636 1

7 packages built:
- kodiPlugins.steam-launcher
- linux-steam-integration
- lutris
- steam
- steam-run
- steam-run-native
- steamcmd

@flokli flokli merged commit c1c055b into NixOS:release-20.03 May 4, 2020
@prusnak prusnak deleted the 20.03-steam branch May 4, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@tadfisher tadfisher Awaiting requested review from tadfisher

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: steam 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prusnak @flokli @mweinelt @jonringer @nyanloutre