Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o, cri-tools: install completion, manpages #86638

Merged
merged 2 commits into from May 7, 2020
Merged

cri-o, cri-tools: install completion, manpages #86638

merged 2 commits into from May 7, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 3, 2020 •
edited

Waiting for changes to land in master.

@zowoq zowoq marked this pull request as ready for review May 6, 2020 06:46
saschagrunert
saschagrunert approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the nice cleanup!

@saschagrunert
Copy link
Member

saschagrunert commented May 6, 2020 •
edited

Will conflict with #86378 (from code, not logically)

@marsam marsam merged commit 9d959ff into NixOS:master May 7, 2020
@zowoq zowoq deleted the cri-shell branch May 7, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @saschagrunert @marsam