Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cnijfilter2: 5.70 -> 5.90 #86635

Merged
merged 1 commit into from May 5, 2020
Merged

cnijfilter2: 5.70 -> 5.90 #86635

merged 1 commit into from May 5, 2020

Conversation

ktor
Copy link
Member

@ktor ktor commented May 3, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) - tested the driver with Canon PIXMA G5040
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ktor ktor requested a review from aszlig May 3, 2020 08:22
@ofborg ofborg bot requested a review from cstrahan May 3, 2020 08:29
@ktor ktor force-pushed the ktor/cnijfilter2-version-update branch from b800c8f to 40fa456 Compare May 3, 2020 16:29
@bhipple
Copy link
Contributor

bhipple commented May 5, 2020

Result of nixpkgs-review pr 86635 1

1 package built:
- cnijfilter2

@bhipple bhipple merged commit d161e20 into NixOS:release-20.03 May 5, 2020
@ktor ktor deleted the ktor/cnijfilter2-version-update branch May 6, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@aszlig aszlig aszlig approved these changes

@bhipple bhipple bhipple approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktor @bhipple @prusnak @aszlig