Workers: test where Worker/SharedWorker are exposed #23381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove broken tests. For whatwg/html#5497.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Jun 2, 2020
Tests: web-platform-tests/wpt#23381. Closes #5497.
3 tasks
foolip
approved these changes
Jun 3, 2020
| // META: global=window,worker | ||
|
|
||
| test(() => { | ||
| // Use onfetch as service worker detector |
There was a problem hiding this comment.
How about just globalThis.ServiceWorkerGlobalScope?
|
If I run https://web-platform.test:8443/workers/semantics/multiple-workers/exposure.any.sharedworker.html locally in Chrome Canary I get a harness error and basically no useful information. Not sure what's going on. (All other variants are fine.) |
|
https://wpt.fyi/results/workers/semantics/multiple-workers/exposure.any.sharedworker.html?label=pr_head&max-count=1&pr=23381 looks OK, does it work with |
|
Not sure, not familiar with that way of running tests. |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Jun 3, 2020
Tests: web-platform-tests/wpt#23381. Closes #5497.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove broken tests.
For whatwg/html#5497.