Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

left4gore: Init at 2.3 #86663

Merged
merged 1 commit into from Sep 3, 2020
Merged

left4gore: Init at 2.3 #86663

merged 1 commit into from Sep 3, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented May 3, 2020 •
edited

Motivation for this change

Doesn't work that easily on NixOS due to yama.
Works when quitting steam and launching left4gore -2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested a review from Lassulus July 12, 2020 15:40
@Lassulus
Copy link
Member

Lassulus commented Sep 2, 2020

needs rebase

@dasJ
Copy link
Member Author

dasJ commented Sep 2, 2020

better?

@Lassulus Lassulus merged commit f806b3c into NixOS:master Sep 3, 2020
@dasJ dasJ deleted the init-left4gore branch September 3, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasJ @Lassulus