Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytest: 5.3.5 -> 5.4.1 #86735

Closed
wants to merge 3 commits into from
Closed

python3Packages.pytest: 5.3.5 -> 5.4.1 #86735

wants to merge 3 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 4, 2020 •
edited

Motivation for this change

attempt at #83675 again, this time giving a month for the ecosystem to adjust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner May 4, 2020 07:53
@ofborg ofborg bot requested review from lsix, lovek323, madjar and domenkozar May 4, 2020 08:02
@jonringer jonringer mentioned this pull request May 4, 2020
Merged
10 tasks
@FRidh FRidh self-assigned this May 9, 2020
@drewrisinger
Copy link
Contributor

FYI, looks pytest was updated to 5.4.2 in the meantime. https://docs.pytest.org/en/latest/changelog.html

drewrisinger
drewrisinger approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Didn't build. nix-review doesn't work because of merge conflicts.

@jonringer
Copy link
Contributor Author

This was cherry-picked into python-unstable, then merged into staging, now in #87814

@jonringer jonringer closed this May 15, 2020
@jonringer
Copy link
Contributor Author

the conflicts were because staging is now at 5.4.2

@jonringer jonringer deleted the bump-pytest branch August 15, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@lsix lsix Awaiting requested review from lsix

@lovek323 lovek323 Awaiting requested review from lovek323

@madjar madjar Awaiting requested review from madjar

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @drewrisinger @FRidh