Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Clarify some contribution guidelines #8107

Merged
merged 1 commit into from May 3, 2020

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented May 3, 2020

No description provided.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@James103
Copy link
Contributor

James103 commented May 3, 2020

In the OpenTTD CI, the Windows and macOS checks are failing in "Install OpenGFX" because https://cdn.openttd.org/opengfx/0.5.2/opengfx-0.5.2-all.zip is returning a 404 error. The URL should be changed to https://cdn.openttd.org/opengfx-releases/0.5.2/opengfx-0.5.2-all.zip to prevent further errors.

@nielsmh
Copy link
Contributor Author

nielsmh commented May 3, 2020

Yes but that's a fix for #8105 not this PR.

Point out that translations should be fixed via the web translator.
Clerify that "changed NewGRFs" means after the game was started, not that any game using NewGRFs is invalid for bug reports.

2. **Use the GitHub issue search** --- check if the issue has already been
2. **Use the GitHub issue search** check if the issue has already been
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change, ooi?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When viewed in proportional fonts, a proper em-dash looks better than three hyphens. So entirely cosmetic.

@andythenorth
Copy link
Contributor

I'm assuming the checks are stuck. Because this diff is clearly docs-only, I'm approving it.

@LordAro LordAro merged commit fde28ec into OpenTTD:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants