Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xp-pen-g430: rename to pentablet-driver & 20190820 -> 1.2.13.1 #86666

Merged
merged 2 commits into from May 6, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented May 3, 2020

Motivation for this change

Renamed the xp-pen-g430 package to pentablet-driver, as i noticed all drivers in this series are exactly the same. Also updated it from 20190820 -> 1.2.13.1.

I'm copying them to $out/bin seperately now as to not have the annoying capitalization of the executable. Note that config.xml has to be next to the executable for it to start.

Their versioning is a tad confusing but this came out like 5 months later, so I'm sure it's newer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the following to the pkgs/top-level/aliases.nix:

xp-pen-g430 = pentablet-driver; # added 2020-05-03

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented May 3, 2020

Maybe also add the following to the pkgs/top-level/aliases.nix:

xp-pen-g430 = pentablet-driver; # added 2020-05-03

Done 👍

Edit: Oops, had a typo. fixed.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@veprbl veprbl merged commit f46cbbc into NixOS:master May 6, 2020
@IvarWithoutBones IvarWithoutBones deleted the pentablet-driver branch May 6, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants