gcc9: don't run patchELF on statically linked binaries #89030
Conversation
This produces an error, at least when cross compiling statically for AArch32.
| @@ -241,7 +241,7 @@ postInstall() { | |||
| # More dependencies with the previous gcc or some libs (gccbug stores the build command line) | |||
| rm -rf $out/bin/gccbug | |||
|
|
|||
| if type "patchelf"; then | |||
| if [ -n "${dontPatchELF}" ] && type "patchelf"; then | |||
There was a problem hiding this comment.
this should be -z i think?
There was a problem hiding this comment.
Good point... that probably means that this isn't being set properly on the static builds! I'll look into it.
There was a problem hiding this comment.
I changed this locally and am re-running the build.
There was a problem hiding this comment.
Yeah, so adding assert staticCompiler; to this expression fails, I guess that isn't acutally set in static.nix. I could add an override for GCC, but there's the added complication of it being used in the stdenv, and being wrapped by wrapCC. @matthewbauer do you have any advice on how I could cause this variable to be set when building pkgsStatic.gcc?
There was a problem hiding this comment.
yeah i think that will work
There was a problem hiding this comment.
static.nix should only apply to the things in pkgsStatic, so I think it will actually be okay here
|
I'm unmotivated to figure this one out. Sorry! |
This produces an error, at least when cross compiling statically for AArch32.
Motivation for this change
Fixes #88956
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)