Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scikit-optimize: 0.6 -> 0.7.4 #89013

Closed
wants to merge 1 commit into from
Closed

scikit-optimize: 0.6 -> 0.7.4 #89013

wants to merge 1 commit into from

Conversation

jethrokuan
Copy link
Contributor

@jethrokuan jethrokuan commented May 27, 2020 •
edited

Motivation for this change

Updates scikit-optimize to 0.7.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc May 27, 2020 12:12
jonringer
jonringer reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ensure the package still builds

pkgs/development/python-modules/scikit-optimize/default.nix Show resolved Hide resolved
jonringer
jonringer reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.scikit-optimize: 0.6 -> 0.7.4

also, please squash all fixups

@Lassulus
Copy link
Member

getting this error with nix-review:

builder for '/nix/store/9zqhqmbchwp8b6n5bwbqa13b039748z5-tensorflow-1.15.2.drv' failed with exit code 1; last 10 log lines:
      [Analy] Compiling .../eager/kernel_and_device.cc [for host]; 334s
      [Analy] Compiling tensorflow/c/kernels/bitcast_op.cc; 334s
      [Analy] Compiling tensorflow/c/kernels/bitcast_op.cc [for host]; 334s
      [Analy] Compiling .../common_runtime/eager/context.cc [for host]; 334s
      [Analy] Compiling .../eager/tensor_handle_data.cc [for host]; 334s
      [Analy] .../distributed_runtime/eager:remote_tensor_handle_data; 333s ...
  FAILED: Build did NOT complete successfully
  FAILED: Build did NOT complete successfully
  
  builder for '/nix/store/9zqhqmbchwp8b6n5bwbqa13b039748z5-tensorflow-1.15.2.drv' failed with exit code 1
cannot build derivation '/nix/store/sbzq5cg1zmcffyfswnh0j0fhg044w43v-python3.7-tensorflow-1.15.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/27qdxas0as50zmc02y5k7pglsdnbkmrq-python3.7-optuna-0.19.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/x40nlmcc1hn5pb3p6kfmplzmddcvkd47-env.drv': 3 dependencies couldn't be built

@jonringer
Copy link
Contributor

that's because tensorflow is broken on master

@risicle
Copy link
Contributor

risicle commented Oct 5, 2020

Superseded by #97990

@risicle risicle closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jethrokuan @Lassulus @jonringer @risicle @ryantm