Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group packages by language/builder via dummy maintainer #89017

Merged
merged 4 commits into from Jul 17, 2020
Merged

Group packages by language/builder via dummy maintainer #89017

merged 4 commits into from Jul 17, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 27, 2020

I'd like to sort these by language/builder for repology, e.g. being able to see which rust packages are outdated.

cc @grahamc @infinisil

I don't think this will cause any problems with ofborg, rfc33 or the github id checks?

@grahamc
Copy link
Member

grahamc commented May 27, 2020

How about we make a maintainer team for these two, and somehow teach repology about maintainer teams?

@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2020

How about we make a maintainer team for these two, and somehow teach repology about maintainer teams?

That sounds good but I'd still like to see this merged for now and then switched over to that when it's implemented.

@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2020

@grahamc speaking of teams, could you take a look at #84177 (comment) please?

@zowoq
Copy link
Contributor Author

zowoq commented May 28, 2020

How about we make a maintainer team for these two, and somehow teach repology about maintainer teams?

@grahamc Could you please clarify if this a blocker?

@mdlayher
Copy link
Member

Reviewing some old "topic: golang" PRs.

It seems like the approach in #84177 is the preferred one? I'd be happy to be part of a Go maintainer team.

@zowoq
Copy link
Contributor Author

zowoq commented Jun 25, 2020

It seems like the approach in #84177 is the preferred one?

No, this is works differently. Currently a team is just a pointer to a list of people and not an entity in itself so it isn't useful for repology.

I'd be happy to be part of a Go maintainer team.

I made a team for Golang compliers in #90225, feel free to open a PR to add yourself.

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, done thanks!

Although I have limited experience, this does seem like a reasonable step to me, assuming the repology changes would be more involved. LGTM.

@zowoq
Copy link
Contributor Author

zowoq commented Jun 28, 2020

@grahamc Unless there are objections I'll merge this in a week or so, I'd like to see how useful it is (or isn't) before making wider changes.

@mdlayher
Copy link
Member

@zowoq ping, no objections raised so it feels okay to me to move forward with this as a stop gap to gain useful functionality.

@zowoq zowoq merged commit d5fb235 into NixOS:master Jul 17, 2020
@zowoq zowoq deleted the package-grouping branch July 17, 2020 01:57
@danieldk
Copy link
Contributor

@zowoq feel free to add me to the Rust package maintainers, once you add that team.

@zowoq
Copy link
Contributor Author

zowoq commented Jul 18, 2020

Reverting this in #93394 as ofborg doesn't seem to be able to handle maintainers that don't have github accounts.

@zowoq
Copy link
Contributor Author

zowoq commented Jul 18, 2020

I can't be bothered trying to make changes to ofborg to get this working so I guess this can be considered to be abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants