Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy types (AKA "Holy types, Batman!") #103

Merged
merged 188 commits into from Jul 7, 2020
Merged

Add mypy types (AKA "Holy types, Batman!") #103

merged 188 commits into from Jul 7, 2020

Conversation

adisbladis
Copy link
Member

This is to take steps towards making nixops-aws compatible with NixOps master, and generally improve the code quality.

grahamc added 30 commits May 21, 2020 10:02
@grahamc @adisbladis
pyproject.toml: update to nixops master
05b815b
@grahamc @adisbladis
mypy: add some rules and ignore boto errors
2242145
@grahamc @adisbladis
pre stubs
b94fd1a
@grahamc @adisbladis
sqs_queue: use _connect() to get a connection
e995d8e
@grahamc @adisbladis
sqs_queue: provide config via the new Definiton API
bd4668f
@grahamc @adisbladis
add stubs for boto3
8aeaf5e
@grahamc @adisbladis
sns_topic: access client via _connect()
e018d8f
@grahamc @adisbladis
connect() and _conn -> _connect() to confidently return a client
84f065d
@grahamc @adisbladis
connect_vpc,_conn_vpc -> _connect_vpc()
9e89fc6
@grahamc @adisbladis
connect_route53,_conn_route53 -> _connect_route53()
f5c4d8a
@grahamc @adisbladis
connect_boto3,_conn_boto3 -> _connect_boto3()
1e426e1
@grahamc @adisbladis
Refactor SQSQueue to use ResourceOptions
0d020e7
@grahamc @adisbladis
nixops: use editable source
5d2026e
@grahamc @adisbladis
sqs-queue: fixup Options structure
20281c0
@grahamc @adisbladis
boto3-stubs: support ec2, sqs
43d63b5
@grahamc @adisbladis
s3_bucket: port
682314f
@grahamc @adisbladis
backends/ec2: correct types in physical backup spec assignments
58ae55b
@grahamc @adisbladis
backends/ec2: fixup mypy complaints
e100365
@grahamc @adisbladis
elastic_file_syste_mount_target: fixup missing second parameter
fdfbda6
@grahamc @adisbladis
Finish up connect refactor
6ae512a
@grahamc @adisbladis
elatsic file system: up connect refactor
2b8a0dc
@grahamc @adisbladis
resources/aws_vpn_connection.py: fixup mypy error
b31e4dd
@grahamc @adisbladis
resources/aws_vpn_connection_route.py: fixup mypy
884dbf1
@grahamc @adisbladis
resources/aws_vpn_gateway.py: fixup mypy
e84d31c
@grahamc @adisbladis
resources/vpc: fixup mypy
8be5cbf
@grahamc @adisbladis
fixup imports
d2050cf
@grahamc @adisbladis
unify connect behavior
708bcee
@grahamc @adisbladis
fixup: trivial mypy errors
cbc8329
@grahamc @adisbladis
wip: rds break-out
5acadf3
@grahamc @adisbladis
efs_common: type, confidently pass region
a43adeb
@adisbladis
nixops_aws/resources/route53_recordset.py: Fix flake8 errors
e376fab
@adisbladis
nixops_aws/resources/s3_bucket.py: Fix flake8 errors
a77de4e
@adisbladis
nixops_aws/resources/sns_topic.py: Fix flake8 errors
d73e2a7
@adisbladis
nixops_aws/resources/sqs_queue.py: Fix flake8 errors
72adead
@adisbladis
nixops_aws/resources/vpc.py: Fix flake8 errors
28d65a5
@adisbladis
nixops_aws/resources/vpc_dhcp_options.py: Fix flake8 errors
07edfc0
@adisbladis
nixops_aws/resources/vpc_egress_only_internet_gateway.py: Fix flake8 …
0c87a07 
…errors
@adisbladis
nixops_aws/resources/vpc_endpoint.py: Fix flake8 errors
db717eb
@adisbladis
nixops_aws/resources/vpc_internet_gateway.py: Fix flake8 errors
8e662c6
@adisbladis
nixops_aws/resources/vpc_nat_gateway.py: Fix flake8 errors
02737f7
@adisbladis
nixops_aws/resources/vpc_network_acl.py: Fix flake8 errors
9e56090
@adisbladis
nixops_aws/resources/vpc_network_interface.py: Fix flake8 errors
31a560e
@adisbladis
nixops_aws/resources/vpc_network_interface_attachment.py: Fix flake8 …
2409275 
…errors
@adisbladis
nixops_aws/resources/vpc_route.py: Fix flake8 errors
30511ea
@adisbladis
nixops_aws/resources/vpc_route_table.py: Fix flake8 errors
c0c3492
@adisbladis
nixops_aws/resources/vpc_route_table_association.py: Fix flake8 errors
4e5da45
@adisbladis
nixops_aws/resources/vpc_subnet.py: Fix flake8 errors
36860be
@adisbladis
Add flake8 dependency
3a9594a
@adisbladis
Add flake8 ci job
f349c90
@adisbladis
Add mypy ci job
ea99f71
@adisbladis
Copy link
Member Author

The mypy failure is because NixOS/nixops#1355 is not merged yet.

@adisbladis adisbladis merged commit 0853724 into NixOS:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @grahamc