Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findutils: fix undeclared xargs dep on echo #89063

Merged
merged 1 commit into from Jun 14, 2020

Conversation

abathur
Copy link
Member

@abathur abathur commented May 27, 2020

When invoked without a command parameter, xargs runs echo from PATH.
This change patches xargs to use a specific Nix-built echo.

Motivation for this change

Fix #89055

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a mass rebuild, so please target the staging branch.

pkgs/tools/misc/findutils/default.nix Outdated Show resolved Hide resolved
When invoked without a command parameter, xargs runs echo from PATH.
This change patches xargs to use a specific Nix-built echo.
@abathur
Copy link
Member Author

abathur commented May 28, 2020

This will be a mass rebuild, so please target the staging branch.

I changed the target branch but it started listing other commits in addition to mine, so I've re-built the commit from staging and force-pushed. Hopefully that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

findutils/xargs has a subtle undeclared runtime dependency on an external echo command
3 participants