Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.deepin-screenshot: remove (has been archived upstream) #89040

Merged
merged 1 commit into from May 28, 2020
Merged

deepin.deepin-screenshot: remove (has been archived upstream) #89040

merged 1 commit into from May 28, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 27, 2020

Motivation for this change

It has been deprecated (migrated to deepin-screen-recorder after v20).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It has been deprecated (migrated to deepin-screen-recorder after v20).
@flokli
Copy link
Contributor

flokli commented Jun 12, 2020

deepin-screen-recorder isn't packaged, and when removing packages we usually provide a message in aliases.nix, pointing users to alternatives.

Simply removing it without anyone else reviewing this PR is probably not what should happen usually. I was quite confused seeing deepin.deepin-screenshot just disappeared, and even more when the suggested alternative isn't in nixpkgs.

Do you plan to introduce deepin-screen-recorder to nixpkgs, or what's the plan forward?

Also cc @worldofpeace for the deepin ecosystem.

@romildo
Copy link
Contributor Author

romildo commented Jun 12, 2020

Do you plan to introduce deepin-screen-recorder to nixpkgs, or what's the plan forward?

Yes, deepin-screen-recorder introduction to nixpkgs is planned.

@romildo romildo deleted the upd.deepin-screenshot branch August 17, 2020 11:24
@asdf8dfafjk
Copy link
Contributor

I haven't tried deepin-screen-recorder but I am going to assume its going to be much more heavy than deepin-screenshot. Unless screenshot was actually broken, I don't see why it was removed at all.

Also, I (with my limited knowledge) fail to see an adversarial model where it would be considered "insecure" to use deepin-screenshot.

To top it all, it's probably always best to wait for a replacement and then delete, and at least please get a review.

@romildo
Copy link
Contributor Author

romildo commented Aug 30, 2020

I am sorry I have deleted it without a review :(

The situation now is that deepin is replacing its applications by new ones and the old ones are not being developed anymore.

Most of deepin packages in nixpkgs are more than one year old and they are getting broken. Fixing them would mean updating to the new versions. But the new versions released by upstream focus on new implmentations, using a new design and they are still buggy.

It seems that packaging deepin desktop and applications has become impracticable now, as discussed here, and there is a PR to remove them.

@asdf8dfafjk
Copy link
Contributor

Thank you for so much work you do on NixOS :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants