This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
reduce the size of the base image #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
changed the title
prusnak
changed the title
|
Amended to include nix 2.3.6 which was released meanwhile |
This is a breaking change! Users need to add the following into their Dockerfile files: RUN nix-channel --add https://nixos.org/channels/nixpkgs-unstable RUN nix-channel --update
|
I think we can also remove these 3 lines because they are essentially a no-op now, but it does not hurt to keep them either: Lines 21 to 23 in d4965ab |
|
What makes you say those lines were a no-op? |
peti
suggested changes
Jun 7, 2020
peti
reviewed
Jun 7, 2020
| RUN wget https://nixos.org/releases/nix/nix-${NIX_VERSION}/nix-${NIX_VERSION}-x86_64-linux.tar.xz \ | ||
| && tar xf nix-${NIX_VERSION}-x86_64-linux.tar.xz \ | ||
| && addgroup -g 30000 -S nixbld \ | ||
| && for i in $(seq 1 30); do adduser -S -D -h /var/empty -g "Nix build user $i" -u $((30000 + i)) -G nixbld nixbld$i ; done \ | ||
| && mkdir -m 0755 /etc/nix \ | ||
| && echo 'sandbox = false' > /etc/nix/nix.conf \ | ||
| && mkdir -m 0755 /nix && USER=root sh nix-${NIX_VERSION}-x86_64-linux/install \ | ||
| && mkdir -m 0755 /nix && USER=root sh nix-${NIX_VERSION}-x86_64-linux/install --no-channel-add \ |
There was a problem hiding this comment.
We can't add that change to this image because the change would break everyone's scripts and CI setups. Our users rely on the channel being registered.
prusnak
changed the title
|
Upon further investigation, I realized the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18 by using
--no-channel-addoption to reduce the size of the base imageThis is a breaking change! Users need to add the following into their Dockerfile files: