Fixed PackedByteArray GDScript functions #39100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with this script: func _ready():
var plain := "Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions Test PBA functions "
var utf8Bytes := plain.to_utf8()
print(utf8Bytes)
print("utf8Bytes: %d" % utf8Bytes.size())
var xStr := utf8Bytes.get_string_from_utf8()
print("xStr: " + xStr)
var compressedBytes := utf8Bytes.compress(File.COMPRESSION_GZIP)
print("compressedBytes: %d" % compressedBytes.size())
var decompressedBytes := compressedBytes.decompress(utf8Bytes.size(), File.COMPRESSION_GZIP)
print("decompressedBytes: %d" % decompressedBytes.size())
var decStr := decompressedBytes.get_string_from_utf8()
print("decStr: %d" % decStr.length())
print("'%s'" % decStr)
var decStrAscii := decompressedBytes.get_string_from_ascii()
print("decStr: %d" % decStrAscii.length())
print("'%s'" % decStrAscii) |
Faless
reviewed
Sep 4, 2020
p_self._data.packed_array needs to be used instead of p_self._data._mem printline
Wavesonics
force-pushed
the
pool-byte-array-fix
branch
from
fb3221f
to
8f1a6d7
Compare
|
Thanks! |
This was referenced Sep 7, 2020
|
Would be nice if this can be cherry-picked to 3.2.x in the next few months as I'm using these compression functions in production atm. |
|
Can't be cherry picked, because |
|
Well now that you mention it, I think this isn't an issue on 3.x, I just mixed up between projects. I'll open a new issue if it comes up with the 3.x branch instead of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like with the switch to PackedByteArray from the PoolArray types, the GDScript functions weren't updated correctly.
p_self._data.packed_arrayneeds to be used instead ofp_self._data._memThese functions are now fixed:
Edit: Fixes #36611