installer: don't require xz on darwin #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS the system tar has builtin support for lzma while xz isn't available as a separate binary. There's no builtin package manager there available either so having to install lzma (without nix) would be rather painful.
|
Weird, I tested it on github actions, but it seems like that has |
domenkozar
approved these changes
May 27, 2020
|
We didn't check this part, unless you also built and tested the full installer script (pre tarball). |
|
The code path in the PR is part of https://nixos.org/nix/install/ script, so I'm not sure what you mean. |
|
@domenkozar I also came across this. This does not make a good first impression. Could we have a patch release for this? Otherwise it works perfect on Catalina! |
|
@Mic92 it seems like Eelco already prepared 2.3.6 release so it should be done soon :) |
aherrmann
added a commit
to tweag/rules_haskell
that referenced
this pull request
Jun 2, 2020
`xz` is required by the Nix installer to avoid the following error ``` sh: you do not have 'xz' installed, which I need to unpack the binary tarball ``` Eventually that dependency should be removed on MacOS, see NixOS/nix#3632, but at the time of writing this change is not available, yet. ``` $ curl -L https://nixos.org/nix/install | grep -C1 require_util\ xz require_util tar "unpack the binary tarball" require_util xz "unpack the binary tarball" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS the system tar has builtin support for lzma while xz isn't
available as a separate binary. There's no builtin package manager
there available either so having to install lzma (without nix) would be
rather painful.
Alternative to adding this condition would be to revert #3431, in which case potentially more works out of the box but with the downside of worse error handling.
/cc @domenkozar