Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.thinc: 7.4.0 -> 7.4.1 #89004

Closed
wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-thinc/versions.

meta.description for python27Packages.thinc is: "Practical Machine Learning for NLP in Python"

meta.homepage for python27Packages.thinc is: "https://github.com/explosion/thinc"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
30 total rebuild path(s)

8 package rebuild(s)

8 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
8 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python27Packages.spacy
python27Packages.thinc
python37Packages.spacy
python37Packages.textacy
python37Packages.thinc
python38Packages.spacy
python38Packages.textacy
python38Packages.thinc
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/rsbfl33b7qz7gm14p49h47a4rbgg2b1x-python2.7-thinc-7.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python27Packages.thinc https://github.com/r-ryantm/nixpkgs/archive/2886d778401338af3d83e00ee5ddafb7197be1a7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/rsbfl33b7qz7gm14p49h47a4rbgg2b1x-python2.7-thinc-7.4.1
ls -la /nix/store/rsbfl33b7qz7gm14p49h47a4rbgg2b1x-python2.7-thinc-7.4.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

5 packages failed to build:
- python27Packages.spacy
- python37Packages.spacy
- python37Packages.textacy
- python38Packages.spacy
- python38Packages.textacy
3 packages built:
- python27Packages.thinc
- python37Packages.thinc
- python38Packages.thinc

Maintainer pings

cc @aborsu @danieldk @sdll for testing.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual with spaCy, all packages need to be updated in concert. In this case, spaCy hard-depends on thinc == 7.4.0. We could relax the dependency to 7.4.* and see if spaCy still works.

@danieldk
Copy link
Contributor

Extended in #89022 to patch spaCy to work with this version of thinc.

@bhipple bhipple closed this Jun 4, 2020
@r-ryantm r-ryantm deleted the auto-update/python2.7-thinc branch June 6, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants