Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.nodeenv: add setuptools to propagatedBuildInputs #89010

Merged
merged 1 commit into from
May 27, 2020
Merged

pythonPackages.nodeenv: add setuptools to propagatedBuildInputs #89010

merged 1 commit into from
May 27, 2020
+5 −1

Conversation

kalekseev
Copy link
Contributor

Motivation for this change

Was working on #88456 and found that nodeenv doesn't work, that PR is a fix proposed by @FRidh in #88456 (comment)

Problem:

❯ nodeenv
Traceback (most recent call last):
  File "/nix/store/li46lf445jpcj451c5rq6pd5hhj4frg3-python3.7-nodeenv-1.3.3/bin/.nodeenv-wrapped", line 6, in <module>
    from nodeenv import main
  File "/nix/store/li46lf445jpcj451c5rq6pd5hhj4frg3-python3.7-nodeenv-1.3.3/lib/python3.7/site-packages/nodeenv.py", line 43, in <module>
    from pkg_resources import parse_version
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@kalekseev kalekseev requested review from FRidh and jonringer as code owners May 27, 2020 10:05
@kalekseev kalekseev mentioned this pull request May 27, 2020
Merged
@FRidh
Copy link
Member

FRidh commented May 27, 2020

@GrahamcOfBorg build pythonPackages.nodeenv python3Packages.nodeenv

jonringer
jonringer approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89010 1

6 packages built:
- pre-commit (gitAndTools.pre-commit ,python37Packages.pre-commit)
- python27Packages.nodeenv
- python27Packages.pre-commit
- python37Packages.nodeenv
- python38Packages.nodeenv
- python38Packages.pre-commit

@jonringer
Copy link
Contributor

@kalekseev thanks for opening your first PR to nixpkgs :)

@jonringer jonringer merged commit 3795449 into NixOS:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalekseev @FRidh @jonringer