Skip to content

dvb_apps: fix broken package #89023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

dvb_apps: fix broken package #89023

wants to merge 1 commit into from
+153 −7

Conversation

emanueleperuffo
Copy link
Contributor

@emanueleperuffo emanueleperuffo commented May 27, 2020 •
edited
Loading

Motivation for this change

Package dvb_apps was broken and quite old.
This PR upgrades it to its latest version and applies the same patches applied by ArchLinux.

Things done

I've updated the package and applied patches, according to https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=linuxtv-dvb-apps.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 27, 2020
markuskowa
markuskowa requested changes May 31, 2020
View reviewed changes
pkgs/applications/video/dvb-apps/default.nix
buildInputs = [ perl ];
buildInputs = [ perl pkgsi686Linux.glibc.static ];

patches = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchpatch to pull the patches via URL instead of adding them nixpkgs.

pkgs/applications/video/dvb-apps/default.nix

stdenv.mkDerivation {
name = "dvb-apps-7f68f9c8d311";
pkgsi686Linux.stdenv.mkDerivation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgsi686Linux is an odd choice here. It restricts it to i686 only!? Just stdenv.mkDerivation should be fine here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but it was compiling with errors. This is the only way that worked and I didn't have much time to inspect the issues better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is 0003-handle-static-shared-only-build.patch which causes that problem. If you remove that patch it compiles with stdenv.mkDerivation. We do not really need that patch anyway. It would be nice if the build system honors static/shared but it does not hurt here to have both static and shared libs in the same output..

@stale
Copy link

stale bot commented Nov 27, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 27, 2020
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@wegank
Copy link
Member

wegank commented Jan 24, 2023

dvb_apps has been removed in 2020.

@wegank wegank closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emanueleperuffo @wegank @markuskowa @SuperSandro2000