dvb_apps: fix broken package #89023
dvb_apps: fix broken package #89023
Conversation
| buildInputs = [ perl ]; | ||
| buildInputs = [ perl pkgsi686Linux.glibc.static ]; | ||
|
|
||
| patches = [ |
There was a problem hiding this comment.
Please use fetchpatch to pull the patches via URL instead of adding them nixpkgs.
|
|
||
| stdenv.mkDerivation { | ||
| name = "dvb-apps-7f68f9c8d311"; | ||
| pkgsi686Linux.stdenv.mkDerivation { |
There was a problem hiding this comment.
pkgsi686Linux is an odd choice here. It restricts it to i686 only!? Just stdenv.mkDerivation should be fine here.
There was a problem hiding this comment.
I tried, but it was compiling with errors. This is the only way that worked and I didn't have much time to inspect the issues better.
There was a problem hiding this comment.
It is 0003-handle-static-shared-only-build.patch which causes that problem. If you remove that patch it compiles with stdenv.mkDerivation. We do not really need that patch anyway. It would be nice if the build system honors static/shared but it does not hurt here to have both static and shared libs in the same output..
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
dvb_apps has been removed in 2020. |
Motivation for this change
Package dvb_apps was broken and quite old.
This PR upgrades it to its latest version and applies the same patches applied by ArchLinux.
Things done
I've updated the package and applied patches, according to https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=linuxtv-dvb-apps.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)