python27Packages.thinc: 7.4.0 -> 7.4.1 #89022
Conversation
ofborg
bot
added
11.by: package-maintainer
| @@ -53,6 +53,10 @@ buildPythonPackage rec { | |||
| # ${python.interpreter} -m pytest spacy/tests --vectors --models --slow | |||
| # ''; | |||
|
|
|||
| postPatch = '' | |||
| substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<7.5.0" | |||
There was a problem hiding this comment.
We should take up to the next major bump, minor bumps shouldn't introduce breaking changes. Also we will have to revisit this again if they do another minor bump
| substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<7.5.0" | |
| substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<8" |
There was a problem hiding this comment.
I was a bit hesitant, since IIRC they broke something before in a minor bump (which is probably why they set a hard constraint). But since they are working on thinc 0.8 now, it's not very likely to break now.
It seems that GH's suggest functionality cannot amend an existing commit, so I have just manually updated with your suggestion. Thanks!
There was a problem hiding this comment.
I was a bit hesitant, since IIRC they broke something before in a minor bump (which is probably why they set a hard constraint). But since they are working on thinc 0.8 now, it's not very likely to break now.
This is why tests are important :), so we should see breakages if thinc is updated.
Either way, nix doesn't follow conventional python version bound guidelines anyway.
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 89022 1
8 packages built:
- python27Packages.spacy
- python27Packages.thinc
- python37Packages.spacy
- python37Packages.textacy
- python37Packages.thinc
- python38Packages.spacy
- python38Packages.textacy
- python38Packages.thinc
Motivation for this change
Extension of #89004 to also patch spaCy to work with the thinc update.
Tested with the annotation example from the spaCy website.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)