Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.thinc: 7.4.0 -> 7.4.1 #89022

Merged
merged 2 commits into from May 28, 2020
Merged

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Extension of #89004 to also patch spaCy to work with the thinc update.

Tested with the annotation example from the spaCy website.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -53,6 +53,10 @@ buildPythonPackage rec {
# ${python.interpreter} -m pytest spacy/tests --vectors --models --slow
# '';

postPatch = ''
substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<7.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take up to the next major bump, minor bumps shouldn't introduce breaking changes. Also we will have to revisit this again if they do another minor bump

Suggested change
substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<7.5.0"
substituteInPlace setup.cfg --replace "thinc==7.4.0" "thinc>=7.4.0,<8"

Copy link
Contributor Author

@danieldk danieldk May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit hesitant, since IIRC they broke something before in a minor bump (which is probably why they set a hard constraint). But since they are working on thinc 0.8 now, it's not very likely to break now.

It seems that GH's suggest functionality cannot amend an existing commit, so I have just manually updated with your suggestion. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit hesitant, since IIRC they broke something before in a minor bump (which is probably why they set a hard constraint). But since they are working on thinc 0.8 now, it's not very likely to break now.

This is why tests are important :), so we should see breakages if thinc is updated.

Either way, nix doesn't follow conventional python version bound guidelines anyway.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89022 1

8 packages built:
- python27Packages.spacy
- python27Packages.thinc
- python37Packages.spacy
- python37Packages.textacy
- python37Packages.thinc
- python38Packages.spacy
- python38Packages.textacy
- python38Packages.thinc

@jonringer jonringer merged commit 8c5f4b8 into NixOS:master May 28, 2020
@danieldk danieldk deleted the thinc-7.4.1 branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants