Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morph: 1.4.0 -> 1.5.0 #89020

Merged
merged 1 commit into from May 27, 2020
Merged

morph: 1.4.0 -> 1.5.0 #89020

merged 1 commit into from May 27, 2020

Conversation

johanot
Copy link
Contributor

@johanot johanot commented May 27, 2020

Motivation for this change

Bump morph to latest released version.

also; make package more easily patchable by delaying to postPatch and not
referring to $src.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

morph: 1.4.0 -> 1.5.0
6448b90 
also; make package more patchable by delaying to postPatch and not
referring to $src
@johanot johanot requested a review from mmahut May 27, 2020 12:54
@mmahut
Copy link
Member

mmahut commented May 27, 2020

@GrahamcOfBorg build morph

@mmahut
Copy link
Member

mmahut commented May 27, 2020

@GrahamcOfBorg eval

@mmahut mmahut merged commit a9ecd36 into NixOS:master May 27, 2020
@johanot johanot deleted the morph-improvements branch May 27, 2020 19:44
@johanot
Copy link
Contributor Author

johanot commented May 27, 2020

Thanks @mmahut :) 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @mmahut