Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tellico: init at 3.3.0 #86128

Merged
merged 2 commits into from Jun 19, 2020
Merged

tellico: init at 3.3.0 #86128

merged 2 commits into from Jun 19, 2020

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Apr 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/138

@numkem numkem requested a review from symphorien April 27, 2020 23:51
@symphorien
Copy link
Member

Looks good to me. The application builds and runs fine (I mean a window shows up).
I get this warning

kf5.kdbusaddons: Can not find 'kdeinit5' executable at  "/nix/store/m8grb7wlhjm5prhil3fbw5imr6byiihk-bash-interactive-4.4-p23/bin:/nix/store/sicn6b10ixbs6435d7dr630i2hxphfpr-patchelf-0.9/bin:/nix/store/k930l9lckxjf4zmafv4aapvdbd2sibmj-gcc-wrapper-9.3.0/bin:/nix/store/52x4908vr922dhnxz1i5rfnrsq244vzc-gcc-9.3.0/bin:/nix/store/g5lavnivfasac7m15g3mh9lhmhsr5vl4-glibc-2.30-bin/bin:/nix/store/ca9mkrf8sa8md8pv61jslhcnfk9mmg4p-coreutils-8.31/bin:/nix/store/3gd7zz0s80k50amwzj3015ddz0sd9inl-binutils-wrapper-2.31.1/bin:/nix/store/3b3ighb83nhifa1v4n7855hlbdl1mhf9-binutils-2.31.1/bin:/nix/store/g5lavnivfasac7m15g3mh9lhmhsr5vl4-glibc-2.30-bin/bin:/nix/store/ca9mkrf8sa8md8pv61jslhcnfk9mmg4p-coreutils-8.31/bin:/nix/store/nkmf179c1v5vis7v95dv05vi7r3sk28g-tellico/bin:/nix/store/ca9mkrf8sa8md8pv61jslhcnfk9mmg4p-coreutils-8.31/bin:/nix/store/hg3albf7g05ljfqrfjhd58rblimrp6ph-findutils-4.7.0/bin:/nix/store/k7rakfl1ld9ycfm1zzszly0161h6jlcp-diffutils-3.7/bin:/nix/store/jpqlmf3wqg281j8fdz50kjl525pfsxjc-gnused-4.8/bin:/nix/store/8pajzfyqx1v7dz1znrnrc4pqj5rmnx24-gnugrep-3.4/bin:/nix/store/miwvn81sgbbcq5bfglr6v3pwchgsd00c-gawk-5.0.1/bin:/nix/store/0s93dpvxn7vaaah3n1lgz0q0xqdfsbkj-gnutar-1.32/bin:/nix/store/6yqb5dfmlsx0zr0q8xzi8v4wbrzmvwpf-gzip-1.10/bin:/nix/store/hgp00a1rgwqxjcrkqhbjrfb5df7wjhl5-bzip2-1.0.6.0.1-bin/bin:/nix/store/998ykzc5mazwak08hxayqmyqkyz18fcb-gnumake-4.2.1/bin:/nix/store/kgp3vq8l9yb8mzghbw83kyr3f26yqvsz-bash-4.4-p23/bin:/nix/store/c8nzpy2f2sz0w3mp4x8gkpn4hd4l2420-patch-2.7.6/bin:/nix/store/6ca524vb3yg59ag3khm0010591rny9v1-xz-5.2.5-bin/bin:/nix/store/6ahbx5rlsk68kzbyzhzk74m4ki99wvr1-nix-2.3.4/bin:/nix/store/jw3apqr03z5812anw5c8rdp5iag4n0p2-git-2.25.3/bin:/nix/store/nlgrx0cl1l87nx0w660lb3jksn9jdca9-python3-3.7.6/bin:/nix/store/4i28bbf6hn8k0b1d2an6dzqmyh4vjqnm-nixpkgs-review-2.2.0/bin:/home/symphorien/bin:/run/wrappers/bin:/home/symphorien/.nix-profile/bin:/etc/profiles/per-user/symphorien/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin:/home/symphorien/.fzf/bin" "/nix/store/nkmf179c1v5vis7v95dv05vi7r3sk28g-tellico/bin, /nix/store/wfmrgv16wr5ghxidiasi1cm69bghprd5-qtbase-5.12.7/bin"

but I assume this is because I'm not using plasma.

@numkem numkem requested a review from Lassulus June 18, 2020 21:25
@Lassulus Lassulus merged commit fcbd2e6 into NixOS:master Jun 19, 2020
@numkem numkem deleted the tellico branch June 19, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien Awaiting requested review from symphorien

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numkem @nixos-discourse @symphorien @Lassulus