Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues found in production #10

Merged
merged 4 commits into from Apr 27, 2020
Merged

Fix some issues found in production #10

merged 4 commits into from Apr 27, 2020

Conversation

TrueBrain
Copy link
Member

No description provided.

@TrueBrain
Fix: initialize the git properly if BaNaNaS is not a git folder yet
6defb0e
@TrueBrain
Fix: cancel the task, instead of letting the GC do it for us
cd49c74 
If the GC does it, it gives a big fat warning. Let's avoid that
warning.
@TrueBrain
Fix: remove empty folders after a GitHub update
f0a2708 
Git doesn't track folders, so if all files are removed from a
folder, an empty folder is left behind. This can confuse other
parts of the code.
@TrueBrain
Fix: work around an issue with GitPython being confused if the GC kic…
9f34c6e 
…ks in
@TrueBrain TrueBrain merged commit 7cd73e9 into OpenTTD:master Apr 27, 2020
@TrueBrain TrueBrain deleted the fix_production branch April 27, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosch123 frosch123 frosch123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @frosch123