Skip to content

PULL_REQUEST_TEMPLATE: try to simplify call-for-review #86110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

PULL_REQUEST_TEMPLATE: try to simplify call-for-review #86110

merged 1 commit into from
Apr 27, 2020
+10 −1

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 27, 2020

The text is quite long and hard to read in hub (because it is one whole line
with no line breaks). Also simplified the language/sentence structure a bit for
non-native speakers.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 27, 2020
@Mic92 Mic92 requested review from grahamc and worldofpeace April 27, 2020 11:41
@Mic92 Mic92 force-pushed the pr-template branch 2 times, most recently from dcf1186 to 623e564 Compare April 27, 2020 16:30
@worldofpeace worldofpeace requested a review from infinisil April 27, 2020 17:41
@worldofpeace
Copy link
Contributor

Requested infinisil review since he's the original author of this.

@infinisil
Copy link
Member

Nice, looking good!

@Mic92
PULL_REQUEST_TEMPLATE: try to simplify call-for-review

Verified

This commit was signed with the committer’s verified signature. The key has expired.
CRBroughton Craig R Broughton
GPG key ID: A9923C0202EEA387
Expired
Verified
Learn about vigilant mode
93862d0 
The text is quite long and hard to read in hub (because it is one whole line
with no line breaks). Also simplified the language/sentence structure a bit for
non-native speakers.
@Mic92 Mic92 merged commit 974d11d into NixOS:master Apr 27, 2020
@Mic92 Mic92 deleted the pr-template branch April 27, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

@FRidh FRidh

@cole-h cole-h

@grahamc grahamc

@worldofpeace worldofpeace

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mic92 @worldofpeace @infinisil @veprbl @FRidh @cole-h