Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runc: remove hardeningDisable #86099

Merged
merged 1 commit into from Apr 27, 2020
Merged

runc: remove hardeningDisable #86099

merged 1 commit into from Apr 27, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 27, 2020

Motivation for this change

All other uses of hardeningDisable = [ "fortify" ] in go packages were removed in #72093.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented Apr 27, 2020

@GrahamcOfBorg test podman

@Mic92 Mic92 merged commit a8340a3 into NixOS:master Apr 27, 2020
@zowoq zowoq deleted the runc branch April 27, 2020 06:38
@zowoq zowoq restored the runc branch April 27, 2020 08:06
@zowoq zowoq deleted the runc branch April 27, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@vdemeester vdemeester Awaiting requested review from vdemeester

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @Mic92