Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kops: remove old versions #86112

Merged
merged 2 commits into from Apr 27, 2020
Merged

kops: remove old versions #86112

merged 2 commits into from Apr 27, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from zimbatm April 27, 2020 09:21
@ofborg ofborg bot requested review from offlinehacker and kampka April 27, 2020 09:27
@kampka
Copy link
Contributor

kampka commented Apr 27, 2020

@ofborg build kops_1_16

@kampka kampka mentioned this pull request Apr 27, 2020
Closed
10 tasks
@Mic92 Mic92 merged commit 3a22f3c into NixOS:master Apr 27, 2020
@Mic92 Mic92 deleted the kops branch April 27, 2020 11:24
@ofborg ofborg bot requested review from kampka and zimbatm April 27, 2020 11:31
@kampka
Copy link
Contributor

kampka commented Apr 27, 2020

Thanks for taking care of this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@kampka kampka Awaiting requested review from kampka

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @kampka @zimbatm