Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dqlite: 1.4.0 -> 1.4.1; fix build #86102

Merged
merged 3 commits into from Apr 27, 2020
Merged

dqlite: 1.4.0 -> 1.4.1; fix build #86102

merged 3 commits into from Apr 27, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 27, 2020 •
edited

Motivation for this change

fix hydra build: https://hydra.nixos.org/build/117361754

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from wucke13 and jokogr April 27, 2020 07:24
@Mic92 Mic92 changed the title dqlite: 1.4.0 -> 1.4.1 dqlite: 1.4.0 -> 1.4.1; fix build Apr 27, 2020
@Mic92 Mic92 merged commit 2060bc0 into NixOS:master Apr 27, 2020
@Mic92 Mic92 deleted the dqlite branch April 27, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wucke13 wucke13 Awaiting requested review from wucke13

@jokogr jokogr Awaiting requested review from jokogr

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92