Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jq into path for nix-prefetch-docker #86143

Merged
merged 1 commit into from Apr 28, 2020
Merged

Add jq into path for nix-prefetch-docker #86143

merged 1 commit into from Apr 28, 2020

Conversation

nagisa
Copy link
Contributor

@nagisa nagisa commented Apr 27, 2020 •
edited

Otheriwse running the tool fails with

line 41: jq: command not found
Motivation for this change

See the commit message.

cc @offlinehacker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nagisa
nix-prefetch-docker: Add jq into path
dde3e8e 
Otheriwse running the tool fails with

    line 41: jq: command not found
@nagisa nagisa force-pushed the nix-prefetch-docker-jq-fix branch from 7cc2176 to dde3e8e Compare April 27, 2020 19:22
@ofborg ofborg bot requested a review from offlinehacker April 27, 2020 19:31
@offlinehacker
Copy link
Contributor

Thanks!

@offlinehacker offlinehacker merged commit 87e090c into NixOS:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nagisa @offlinehacker