Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: be36fc67ff0a
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: d0818e2253f6
Choose a head ref
  • 4 commits
  • 7 files changed
  • 3 contributors

Commits on Apr 26, 2020

  1. coreutils: set ac_cv_func_lchmod=no 

    Bumping binutils to 2.32 broke coreutils for unknown reasons[1]. Upon
further investigation we found that there was some issue with mknod
inside a chroot[2][3], which setting ac_cv_func_lchmod to "no" _somehow_
fixes.

We apply this fix and hope to never have to debug this again.

Thanks to @flokli and @LnL7 who helped me chase after this and @pbogdan
who found the fix in the fedora build.

[1]: #85951
[2]: #85951 (comment)
[3]: https://bugzilla.redhat.com/show_bug.cgi?id=1811038
    @lovesegfault
    lovesegfault committed Apr 26, 2020
    Copy the full SHA
    c5e3472 View commit details
    Browse the repository at this point in the history

  2. binutils: 2.31.1 -> 2.33.1 

    - I've removed the stack of patch linked to
https://sourceware.org/bugzilla/show_bug.cgi?id=23428 . The associated
issue says it is closed and targeted for 2.32.

- I've ugraded the "no_plugin" patch. The logic changed in
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=41f37a6fb71f2a3de388108f5cdfca9cbe6e9d51
and I tried to keep the same logic by disabling everything.

It closes #78197
    @guibou @lovesegfault
    guibou authored and lovesegfault committed Apr 26, 2020
    Copy the full SHA
    efdb295 View commit details
    Browse the repository at this point in the history

  3. binutils: 2.33.1 -> 2.34

    @lovesegfault
    lovesegfault committed Apr 26, 2020
    Copy the full SHA
    c5f602f View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Merge pull request #85951 from lovesegfault/binutils-2.34 

    binutils: 2.31.1 -> 2.34
    @flokli
    flokli committed Apr 27, 2020
    Copy the full SHA
    d0818e2 View commit details
    Browse the repository at this point in the history