Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librespot: init a 0.1.1 #86105

Closed
wants to merge 3 commits into from
Closed

librespot: init a 0.1.1 #86105

wants to merge 3 commits into from

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change

wanted a spotify connector that does not depend on a login

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi force-pushed the librespot branch 6 times, most recently from 4f7f112 to 31a7d98 Compare April 29, 2020 15:34
@Lassulus
Copy link
Member

hi, can you split the module and the package in separate commits (same PR is okay)
also new modules are encouraged to have a test. I guess this could be hard to test though, but maybe you can come up with an idea

@Lassulus
Copy link
Member

Lassulus commented May 4, 2020

maybe the same mail for both commits would be nice

@Scriptkiddi Scriptkiddi force-pushed the librespot branch 2 times, most recently from b77bd06 to bcba275 Compare May 6, 2020 14:39
@Lassulus
Copy link
Member

Lassulus commented May 6, 2020

got this:

hash mismatch in fixed-output derivation '/nix/store/r0vcv4zd4dss7rg0sxh66k15vfyqvf22-librespot-0.1.1-vendor.tar.gz':
  wanted: sha256:0d3lcz8r60bz32wc9p8czwxzr0kf7nm41783v0cl0gxb2hl5impc
  got:    sha256:0zi50imjvalwl6pxl35qrmbg74j5xdfaws8v69am4g9agbfjvlms

@Scriptkiddi Scriptkiddi force-pushed the librespot branch 2 times, most recently from e531ebe to fe04f1c Compare May 23, 2020 11:42
Lassulus
Lassulus reviewed May 23, 2020
View reviewed changes
nixos/tests/librespot.nix Outdated Show resolved Hide resolved
Lassulus
Lassulus reviewed May 26, 2020
View reviewed changes
nixos/tests/librespot.nix Outdated Show resolved Hide resolved
@Lassulus
Copy link
Member

hello, this is your CI speaking:

@@ -1,6 +1,4 @@
 start_all()
 machine.wait_for_unit("librespot.service")
-machine.succeed(
-    "curl --insecure -L http://localhost:15353"
-)
+machine.succeed("curl --insecure -L http://localhost:15353")

would reformat /nix/store/l4n84hnrqb7mz6avrdzdff6imq4dhjla-nixos-test-driver-librespot/test-script
Oh no! 💥 💔 💥
1 file would be reformatted.
builder for '/nix/store/0xqvgxpa0anbzwwyqagp7ps8hbykggix-nixos-test-driver-librespot.drv' failed with exit code 1
cannot build derivation '/nix/store/kbhxvjgr9v1xkv9z7zzjy6cra093239l-vm-test-run-librespot.drv': 1 dependencies couldn't be built
error: build of '/nix/store/kbhxvjgr9v1xkv9z7zzjy6cra093239l-vm-test-run-librespot.drv' failed

@Scriptkiddi
Copy link
Contributor Author

@Lassulus

@Lassulus
Copy link
Member

Lassulus commented Jun 2, 2020

and another run later:

...
chine # [   26.987062] systemd[1]: Finished Permit User Sessions.
machine # [   26.996923] nscd[682]: 682 monitoring directory `/etc` (2)
machine # [   27.015134] systemd[1]: Started Getty on tty1.
machine # [   27.020695] systemd[1]: Reached target Login Prompts.
machine: must succeed: curl --insecure -L http://localhost:15353
machine # [   28.013792] 8021q: adding VLAN 0 to HW filter on device eth0
machine # [   27.772391] dhcpcd[611]: eth0: waiting for carrier
machine # [   27.788737] dhcpcd[611]: eth0: carrier acquired
machine # [   28.063288] dhcpcd[611]: DUID 00:01:00:01:26:69:01:b9:52:54:00:12:34:56
machine # [   28.092478] dhcpcd[611]: eth0: IAID 00:12:34:56curl: (
machine # 7) Fa[   28.114928] iled dhcpcd[611]: to ceth0: adding address fe80::5054:ff:fe12:3456onne
machine # ct to localhost port 15353: Connection refused
machine: output:
error: command `curl --insecure -L http://localhost:15353` failed (exit code 7)
cleaning up
killing machine (pid 9)
(0.00 seconds)
builder for '/nix/store/s7zgvrizdyc3r3kj4llldqj6276h2byn-vm-test-run-librespot.drv' failed with exit code 1
error: build of '/nix/store/s7zgvrizdyc3r3kj4llldqj6276h2byn-vm-test-run-librespot.drv' failed

@bachp
Copy link
Member

bachp commented Aug 9, 2020

Librespot is now in nixpkgs via #91015

The service and test would still be interesting tough

@SuperSandro2000
Copy link
Member

@Scriptkiddi please don't merge master into this and rebase it properly.

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@Scriptkiddi Scriptkiddi closed this Jun 9, 2021
@ajs124 ajs124 deleted the librespot branch June 9, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu left review comments

@Lassulus Lassulus Lassulus left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Scriptkiddi @Lassulus @bachp @SuperSandro2000 @misuzu @ryantm