Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeself: 2.4.0 -> 2.4.2 #86156

Merged
merged 1 commit into from May 6, 2020
Merged

makeself: 2.4.0 -> 2.4.2 #86156

merged 1 commit into from May 6, 2020

Conversation

kini
Copy link
Member

@kini kini commented Apr 27, 2020 •
edited

Upstream now provides a Makefile that builds a self-extracting installer and
also has a test target. We don't need the self-extracting installer, but we
might as well build it anyway as an additional test.

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from wmertens April 27, 2020 23:46
@kini
makeself: 2.4.0 -> 2.4.2
3f00b95 
Upstream now provides a Makefile that builds a self-extracting installer and
also has a test target.  We don't need the self-extracting installer, but we
might as well build it anyway as an additional test.
@wmertens wmertens merged commit 8ea1136 into NixOS:master May 6, 2020
@wmertens
Copy link
Contributor

wmertens commented May 6, 2020

Thanks!

@kini kini deleted the makeself-update branch May 6, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kini @wmertens