Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: 28.8.4 -> 28.9.1, add GTK3 option #86157

Merged
merged 1 commit into from
Apr 28, 2020
Merged

palemoon: 28.8.4 -> 28.9.1, add GTK3 option #86157

merged 1 commit into from
Apr 28, 2020
+58 −40

Conversation

OPNA2608
Copy link
Contributor

Motivation for this change

New releases came out. Was hoping the update bot would pick up on them like before but it didn't, prolly due to the project moving to a different location.

Should be backported to release-20.03, due to the usual security updates.

Things done

Src changed to the new location of the project. Configuration updated based on the current build settings requirements. A GTK3 option has been added as it's now officially sanctioned to be used with the official branding. GTK2 still seems to be the default, but I briefly tested a x86_64 GTK3 build and it seemed to work fine. i686 builds is entirely untested on my end.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    531405504 (28.8.1, haven't updated in awhile) -> 474916144
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from AndersonTorres April 27, 2020 23:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 27, 2020
@jonringer
Copy link
Contributor

Was hoping the update bot would pick up on them like before but it didn't

It got caught up on doing a nixpkgs-review on a large rebuild

jonringer
jonringer approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/86157
1 package built:
palemoon

@jonringer jonringer merged commit 1e814e3 into NixOS:master Apr 28, 2020
@OPNA2608 OPNA2608 mentioned this pull request Apr 28, 2020
Merged
10 tasks
@OPNA2608 OPNA2608 deleted the update-palemoon branch May 14, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@AndersonTorres AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OPNA2608 @jonringer