Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnvidia-container: 1.0.0 -> 1.0.6 #86096

Merged
merged 1 commit into from Apr 30, 2020
Merged

libnvidia-container: 1.0.0 -> 1.0.6 #86096

merged 1 commit into from Apr 30, 2020

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Apr 27, 2020

Motivation for this change

Closes #83713

Should be backported to 20.03

Credit to @averelld

CC: @tomberek @tbenst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 86096 1

1 package built: - nvidia-docker

@jonringer jonringer merged commit 4a704c6 into NixOS:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@tomberek tomberek tomberek approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[20.03] nvidia-docker: failure to find libnvidia-ml.so on LD_LIBRARY_PATH
4 participants
@mjlbach @prusnak @tomberek @jonringer