Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixpkgs-review: 2.3.0 -> 2.3.1 #86135

Merged
merged 1 commit into from Apr 27, 2020
Merged

nixpkgs-review: 2.3.0 -> 2.3.1 #86135

merged 1 commit into from Apr 27, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 27, 2020

https://github.com/Mic92/nixpkgs-review/releases/tag/2.3.1

@bhipple
Copy link
Contributor

bhipple commented Apr 27, 2020

Result of nixpkgs-review pr 86135 1

1 package built:
- nixpkgs-review

@bhipple bhipple merged commit 697bff7 into NixOS:master Apr 27, 2020
@bhipple
Copy link
Contributor

bhipple commented Apr 27, 2020

nixpkgs-revew on nixpkgs-review LGTM 👍

@Mic92 Mic92 deleted the nixpkgs-review branch April 28, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @bhipple