Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Actions] Upload standalone executable to GitHub release #108

Closed
wants to merge 1 commit into from

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 27, 2020

I merged it into my master (with a temp commit to disable PyPi stuff. Then I created a release to trigger it.

Seems to work as intended. Actions run log is here.

Hmm I should probably rebase and update the README too. And maybe add the changelog in the zip.

@andythenorth
Copy link
Contributor

We're going to need 0.5.1 soon for #109 so that might be a good live test for this?

Copy link
Contributor

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (though I haven't done asset-uploading before, so can't tell if it is really ok :-p)

@LordAro
Copy link
Member

LordAro commented May 1, 2020

Merged into #113

@LordAro LordAro closed this May 1, 2020
@glx22 glx22 deleted the upload branch May 1, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants