coqPackages coqPackages_8_10 coqPackages_8_11 #86088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build coqPackages coqPackages_8_10 coqPackages_8_11 |
CohenCyril
changed the title
|
@vbgl my build was not triggered, but I intend to simplify my PR a little bit again so wait for my signal. |
- fixed bignum version - fixed coq-bits version - fixed coqprime version - fixed mathcomp and mathcomp extra packages (reworked building scheme and removed unused ssreflect directory) - giving the user access to function filterCoqPackages, because overrideScope' does not re-apply it.
CohenCyril
force-pushed
the
mathcomp-1.11
branch
from
593d2d8
to
597fa61
Compare
|
@GrahamcOfBorg build coqPackages coqPackages_8_10 coqPackages_8_11 |
|
@vbgl can you trigger the builds? Thanks 😸 |
|
No, sorry. The bot seems lazy today. Might be enjoying the beautiful weather outside… |
|
@GrahamcOfBorg build coqPackages coqPackages_8_10 coqPackages_8_11 |
|
@GrahamcOfBorg build coqPackages.mathcomp coqPackages_8_10.mathcomp coqPackages_8_11.mathcomp |
|
@vbgl do you understand why the compilation on darwin is still running??? |
|
Thank you Cyril for taking care of the mathcomp package set! |
|
@vbgl thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The way Coq mathcomp core and extra packages were generated did not allow enough freedom to both limit the number of exposed derivation and dynamically patch one. Now it does and it is highly configurable.
Also:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)