Use the local theme as a requirement #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
daniellimws
force-pushed
the
master_doc
branch
2 times, most recently
from
8a0a2ae
to
4ce9f80
Compare
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
|
@mithro ping |
|
This doesn't seem to use the local theme as a requirement? I would expect the |
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
|
Oh right. I applied the changes in #3 to this branch (renaming |
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
Signed-off-by: Daniel Lim Wee Soong <weesoong.lim@gmail.com>
|
Apparently Checkout the preview. It's our theme now. |
|
I guess this LGTM, I wonder if we can reduce the change delta to upstream however? |
|
What do you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the build error that occurs in #2
Edit: Great! The fix works!