Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk: unbreak on OS X #86151

Closed
wants to merge 1 commit into from
Closed

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Apr 27, 2020

Will attempt backport to release once approved/merged.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added 6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 27, 2020
@bcdarwin bcdarwin requested a review from veprbl April 27, 2020 23:39
@bcdarwin
Copy link
Member Author

Closing in favour of #86142; will do backport later.

@bcdarwin bcdarwin closed this Apr 28, 2020
@bcdarwin bcdarwin deleted the unbreak-vtk7-osx branch June 16, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants