Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl2: fix AArch64 Linux build #86158

Closed
wants to merge 1 commit into from
Closed

acl2: fix AArch64 Linux build #86158

wants to merge 1 commit into from

Conversation

kini
Copy link
Member

@kini kini commented Apr 28, 2020

Motivation for this change

The AArch64 Linux build is broken, so this is an attempt to fix it by backporting a recent bug fix from upstream that isn't in the latest released version (8.3). I don't have an AArch64 machine to test on, so I guess I'll find out if it worked once ofborg tests this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 28, 2020 00:35
@kini kini marked this pull request as draft April 28, 2020 01:16
@kini
Copy link
Member Author

kini commented Apr 28, 2020

Sorry, should have made this a draft. Apparently upstream's bug fix didn't work. Will look into this more later.

@kini
Copy link
Member Author

kini commented Aug 2, 2020

Looks like #85903 will fix this.

@kini kini closed this Aug 2, 2020
@kini kini deleted the acl2-fix-aarch64 branch August 20, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kini