Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde/{kate,konqueror,okular}: decrease text mimetype preference #86147

Merged
merged 1 commit into from Apr 28, 2020
Merged

kde/{kate,konqueror,okular}: decrease text mimetype preference #86147

merged 1 commit into from Apr 28, 2020

Conversation

matthewbauer
Copy link
Member

These .desktop files set InitialPreference>1 which will override other
associations even the .desktop appears first in XDG_DATA_DIRS. This
applies to:

  • org.kde.kate.desktop
  • org.kde.kwrite.desktop
  • kfmclient_html.desktop
  • okularApplication_txt.desktop

Fixes #86137

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer mentioned this pull request Apr 27, 2020
Closed
worldofpeace
worldofpeace suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can we comment why we need to lower initial preference?
(preferably the same comment in every file)

@worldofpeace
Copy link
Contributor

I will test this 👍

@worldofpeace
Copy link
Contributor

A VM with

services.xserver.enable = true;
services.xserver.desktopManager.plasma5.enable = true;
services.xserver.displayManager.sddm.enable = true;
environment.systemPackages = [ pkgs.firefox ];

and the nixos manual desktop file opens in firefox default (and not kate)

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 28, 2020
@matthewbauer
kde/{kate,konqueror,okular}: decrease text mimetype preference
b3f8126 
These .desktop files set InitialPreference>1 which will override other
associations even the .desktop appears first in XDG_DATA_DIRS. This
applies to:

- org.kde.kate.desktop
- org.kde.kwrite.desktop
- kfmclient_html.desktop
- okularApplication_txt.desktop

Fixes NixOS#86137
@jtojnar
Copy link
Contributor

jtojnar commented Apr 28, 2020

Is there an upstream issue/reasoning why they set it so high?

@worldofpeace worldofpeace merged commit bde9441 into NixOS:master Apr 28, 2020
@worldofpeace worldofpeace mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set default browser in Plasma 5 (possible general problem with mimetypes)
3 participants
@matthewbauer @worldofpeace @jtojnar